Adding bash "unoffical strict mode" to setup scripts.#512
Merged
Adding bash "unoffical strict mode" to setup scripts.#512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Fixing #494
This will make the setup script definitely not ignore failures. This is the super-opinionated version where we go 110% strict. If this is too brittle for the style of bash we want to be writing, we could shift back toward vanilla bash by:
If these were removed, the scripts run successfully without the remaining syntax changes
Checklist
lincc-frameworks/python-project-templaterepo and not a downstream one instead.