Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

Add type hints to benchmarks#485

Merged
smcguire-cmu merged 1 commit intomainlincc-frameworks/python-project-template:mainfrom
sean/fix-benchmarks-typinglincc-frameworks/python-project-template:sean/fix-benchmarks-typingCopy head branch name to clipboard
Oct 1, 2024
Merged

Add type hints to benchmarks#485
smcguire-cmu merged 1 commit intomainlincc-frameworks/python-project-template:mainfrom
sean/fix-benchmarks-typinglincc-frameworks/python-project-template:sean/fix-benchmarks-typingCopy head branch name to clipboard

Conversation

@smcguire-cmu
Copy link
Contributor

Change Description

Adds type hints to the example_benchmarks file. Fixes #457

Checklist

  • This PR is meant for the lincc-frameworks/python-project-template repo and not a downstream one instead.
  • This change is linked to an open issue
  • This change includes integration testing, or is small enough to be covered by existing tests

@smcguire-cmu smcguire-cmu merged commit bc8bdee into main Oct 1, 2024
@smcguire-cmu smcguire-cmu deleted the sean/fix-benchmarks-typing branch October 1, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: .initialize_new_project.sh fails with strict mypy when including benchmark files

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.