Fix asv failures and upgrade its default version#482
Merged
camposandro merged 1 commit intomainlincc-frameworks/python-project-template:mainfrom Sep 30, 2024
issue/477/fix-asv-failureslincc-frameworks/python-project-template:issue/477/fix-asv-failuresCopy head branch name to clipboard
Merged
Fix asv failures and upgrade its default version#482camposandro merged 1 commit intomainlincc-frameworks/python-project-template:mainfrom issue/477/fix-asv-failureslincc-frameworks/python-project-template:issue/477/fix-asv-failuresCopy head branch name to clipboard
camposandro merged 1 commit intomainlincc-frameworks/python-project-template:mainfrom
issue/477/fix-asv-failureslincc-frameworks/python-project-template:issue/477/fix-asv-failuresCopy head branch name to clipboard
Conversation
hombit
approved these changes
Sep 30, 2024
Contributor
hombit
left a comment
There was a problem hiding this comment.
Looks very reasonable to me, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolves the Python environment issues experienced in tdastro and nested-dask. For reference, these changes were applied in lincc-frameworks/nested-dask#58 and the workflows are passing again. Closes #477.
What changed
I removed the unnecessary caching of the Python environment and I upgraded the default version to
asv 0.6.4(its latest). The files were also formatted more consistently.Checklist
lincc-frameworks/python-project-templaterepo and not a downstream one instead.