Set .setup_dev.sh script to be executable, and readme to tell folks t…#472
Merged
mtauraso merged 1 commit intomainlincc-frameworks/python-project-template:mainfrom Aug 26, 2024
issue/459/setup-dev-changeslincc-frameworks/python-project-template:issue/459/setup-dev-changesCopy head branch name to clipboard
Merged
Set .setup_dev.sh script to be executable, and readme to tell folks t…#472mtauraso merged 1 commit intomainlincc-frameworks/python-project-template:mainfrom issue/459/setup-dev-changeslincc-frameworks/python-project-template:issue/459/setup-dev-changesCopy head branch name to clipboard
mtauraso merged 1 commit intomainlincc-frameworks/python-project-template:mainfrom
issue/459/setup-dev-changeslincc-frameworks/python-project-template:issue/459/setup-dev-changesCopy head branch name to clipboard
Conversation
This was
linked to
issues
Aug 26, 2024
drewoldag
reviewed
Aug 26, 2024
drewoldag
approved these changes
Aug 26, 2024
Collaborator
drewoldag
left a comment
There was a problem hiding this comment.
Looks good, once that comment is resolved. :)
| ``` | ||
| >> pip install -e .'[dev]' | ||
| >> ./.setup_dev.sh | ||
| >> pre-commit install |
Contributor
There was a problem hiding this comment.
Can remove this line, as pre-commit install is run in /.setup_dev.sh.
Contributor
Author
There was a problem hiding this comment.
Removed this, and altered the note about pre-commit install below.
bc11559 to
f779928
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…o run it
Change Description
Checklist
lincc-frameworks/python-project-templaterepo and not a downstream one instead.