-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Added device support for TRedess Televes CS #18291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
tests/snmpsim/televes-cs.snmprec
Outdated
@@ -0,0 +1,190 @@ | ||
1.3.6.1.2.1.1.1.0|4| | ||
1.3.6.1.2.1.1.2.0|6|.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these two OIDs genuinely return nothing or ..?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the manufacturor of the appliance says they didn not implement the generic snmp objects.
They say they will look in to a fesability study and then maybe implement them in a newer firmware, but i have not heard back from them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is also why the save-snmp-data.php is failing to generate the test data.
group: Channel Out | ||
descr: 'Slot {{ $index }}' | ||
- | ||
oid: muxMeasurementTable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update oid, value and anywhere else an oid is called with the MIB-NAME::OID
format please.
I've made some small tweaks to this PR @OddmarDam. However your test data doesn't actually contain the OID that you're using to do discovery: |
@OddmarDam Still doesn't contain test data for 1.3.6.1.4.1.23180.2.1.1.1.1.8.0 |
Please give a short description what your pull request is for
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>
, i.e./scripts/github-apply 5926
After you are done testing, you can remove the changes with
./scripts/github-remove
. If there are schema changes, you can ask on discord how to revert.