fix: clone Addrs slice before sending on provider channel #1208
+16
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a data race where the same backing array was shared between peerstore and channel consumers. When peerstore modified addresses (TTL expiry, updates), it raced with consumers reading channel data, causing memory corruption (impossible slice state like len=6, cap=3). The fix clones `Addrs` before sending `peer.AddrInfo` on the channel, ensuring each consumer has its own backing array. Should help with ipfs/kubo#11116
This was referenced Dec 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix a data race where the same backing array was shared between peerstore and channel consumers.
When peerstore modified addresses (TTL expiry, updates), it raced with consumers reading channel data, causing memory corruption (impossible slice state like len=6, cap=3).
The fix clones
Addrsbefore sendingpeer.AddrInfoon the channel, ensuring each consumer has its own backing array.