Fix outdated comment#3869
Merged
ethomson merged 2 commits intolibgit2:masterlibgit2/libgit2:masterfrom Aug 4, 2016
richardipsum:fix-outdated-commentrichardipsum/libgit2:fix-outdated-commentCopy head branch name to clipboard
Merged
Fix outdated comment#3869ethomson merged 2 commits intolibgit2:masterlibgit2/libgit2:masterfrom richardipsum:fix-outdated-commentrichardipsum/libgit2:fix-outdated-commentCopy head branch name to clipboard
ethomson merged 2 commits intolibgit2:masterlibgit2/libgit2:masterfrom
richardipsum:fix-outdated-commentrichardipsum/libgit2:fix-outdated-commentCopy head branch name to clipboard
Conversation
SSH transport seems to be supported now.
Style guide says // style comments should be avoided.
Member
|
Thanks for your careful eye! :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
So this is a very trivial pr,
the original comment is from 2012 and seems to no longer apply.
The contribution guidelines suggest // style comments should be avoided,
so I figure I may as well fix that up while I'm here.
Apologies if this is a waste of reviewer time,
but I was working in the perl binding and this comment misled me.
Hope this helps! :)