fetch: Fixed spurious update callback for existing tags.#3812
Merged
ethomson merged 1 commit intolibgit2:masterlibgit2/libgit2:masterfrom Jun 14, 2016
stinb:fetch-tag-update-callbackstinb/libgit2:fetch-tag-update-callbackCopy head branch name to clipboard
Merged
fetch: Fixed spurious update callback for existing tags.#3812ethomson merged 1 commit intolibgit2:masterlibgit2/libgit2:masterfrom stinb:fetch-tag-update-callbackstinb/libgit2:fetch-tag-update-callbackCopy head branch name to clipboard
ethomson merged 1 commit intolibgit2:masterlibgit2/libgit2:masterfrom
stinb:fetch-tag-update-callbackstinb/libgit2:fetch-tag-update-callbackCopy head branch name to clipboard
Conversation
Member
|
This is very minor: I wonder if it would be clearer to write this as This may help us in the future if we want to add additional logic to do with the remote, as right now the conditional seems to be about whether to call the callbacks, but we really want to stop all processing if the ref already existed. If there's additional processing in the future then it may make it more clear. Thanks again for tackling this - and apologies for the delay in reviewing. |
c0e2e7c to
7f9673e
Compare
Contributor
Author
|
Yeah, that makes sense. Updated accordingly. |
Contributor
Author
|
And thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an existing tag is changed on the remote, the default (autotag) behavior is to not overwrite the local tag, but the update callback is still called as if the tag had been updated. This commit fixes that.