Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

New action added to CommentsController, Update Deprecated Rule#3

Open
pHAlkaline wants to merge 3 commits intolecterror:masterlecterror/cakephp-feedback-plugin:masterfrom
pHAlkaline:phalkaline-updatepHAlkaline/cakephp-feedback-plugin:phalkaline-updateCopy head branch name to clipboard
Open

New action added to CommentsController, Update Deprecated Rule#3
pHAlkaline wants to merge 3 commits intolecterror:masterlecterror/cakephp-feedback-plugin:masterfrom
pHAlkaline:phalkaline-updatepHAlkaline/cakephp-feedback-plugin:phalkaline-updateCopy head branch name to clipboard

Conversation

@pHAlkaline
Copy link
Contributor

Delete action added to CommentsController
notEmpty ruedeprecated => notBlank new rule

pHAlkaline added 2 commits December 20, 2016 23:11
@pHAlkaline
Copy link
Contributor Author

Added some more files for plugin domain translation

elementIndex and elementForm , allowing to choose elements outside plugin.
@pHAlkaline
Copy link
Contributor Author

pHAlkaline commented Dec 25, 2016

two new settings added to comments helper :
elementIndex and elementForm , allowing to choose elements outside plugin.
On Controller:
public $helpers = array(
'Feedback.Comments' => array(
'elementIndex'=> 'otherplugin.comment_index',
'elementForm'=> 'otherplugin.comment_add'));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.