add support for Lua 5.4 #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_helpers.c is a copy from luaposix, and needs one trivial change for compatibility with Lua 5.4. luaposix added 5.4 support by appending a `LUA_VERSION_NUM == 504` case to an existing #ifdef for 502 and 503. I chose instead to change it to >= 502, to fix for this 5.4 and avoid encountering this issue again with the next Lua update.
|
can this be merged to support lua 5.4 officially? |
|
Hi, I noticed this PR adds Lua 5.4 support, which would be very helpful for current environments. Thanks for your work on this project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_helpers.c is a copy from luaposix, and needs one trivial change for
compatibility with Lua 5.4. luaposix added 5.4 support by appending
a
LUA_VERSION_NUM == 504case to an existing #ifdef for 502 and 503.I chose instead to change it to >= 502, to fix for this 5.4 and avoid
encountering this issue again with the next Lua update.