feat: [REL-8140] add LaunchDarkly Views resource and data source #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: ffeldberg@launchdarkly.com <ffeldberg@launchdarkly.com>
Co-Authored-By: ffeldberg@launchdarkly.com <ffeldberg@launchdarkly.com>
Co-Authored-By: ffeldberg@launchdarkly.com <ffeldberg@launchdarkly.com>
Co-Authored-By: ffeldberg@launchdarkly.com <ffeldberg@launchdarkly.com>
Co-Authored-By: ffeldberg@launchdarkly.com <ffeldberg@launchdarkly.com>
Co-Authored-By: ffeldberg@launchdarkly.com <ffeldberg@launchdarkly.com>
Co-Authored-By: ffeldberg@launchdarkly.com <ffeldberg@launchdarkly.com>
- Use endpoint construction pattern from access token implementation - Check if endpoint starts with 'http' and prepend 'https://' if not - This should resolve malformed URLs like 'https:///api/v2/projects/...' - Applied to all four HTTP functions: getViewRaw, createView, patchView, deleteView Co-Authored-By: ffeldberg@launchdarkly.com <ffeldberg@launchdarkly.com>
- Replace malformed URL construction that created 'https:///api/v2/...' - Add fallback to 'app.launchdarkly.com' when client.apiHost is empty - Apply fix to all four HTTP functions: getViewRaw, createView, patchView, deleteView - Remove unused 'strings' import - This should resolve TestAccDataSourceView_exists and TestAccDataSourceView_noMatchReturnsError failures Co-Authored-By: ffeldberg@launchdarkly.com <ffeldberg@launchdarkly.com>
- Update Views tests to use newBetaClient pattern like metrics - Modify Views helper functions to use beta client for API calls - Update resource and data source to create and use beta client - Add LD-API-Version: beta header to all Views API requests - This should resolve HTTP 403 errors in TestAccDataSourceView tests Co-Authored-By: ffeldberg@launchdarkly.com <ffeldberg@launchdarkly.com>
- Replace client.fallbackClient.Do() with client.ld.GetConfig().HTTPClient.Do() - This ensures proper authentication and headers are applied to Views API requests - Should resolve TestAccDataSourceView_exists HTTP 403 errors Co-Authored-By: ffeldberg@launchdarkly.com <ffeldberg@launchdarkly.com>
- Change error format from 'HTTP 404' to '404 Not Found' - Ensures TestAccDataSourceView_noMatchReturnsError passes - Maintains consistency with other data source error patterns Co-Authored-By: ffeldberg@launchdarkly.com <ffeldberg@launchdarkly.com>
3 tasks
Co-authored-by: Isabelle Miller <imiller@launchdarkly.com>
|
@sloloris I've just re-requested review, I think I've addressed all of your feedback and added more tests (good shout!) I left one comment unresolved, the deletion of flag links is working as expected right now, is there something that I'm missing? |
sloloris
reviewed
Jul 9, 2025
sloloris
reviewed
Jul 9, 2025
sloloris
reviewed
Jul 9, 2025
| resource.TestCheckResourceAttr(resourceName, ARCHIVED, "false"), | ||
| resource.TestCheckResourceAttr(resourceName, "tags.#", "1"), | ||
| ), | ||
| }, |
There was a problem hiding this comment.
sorryyyy can we add the import verify step on these
There was a problem hiding this comment.
i think that the maintainer thing may cause strange plan outputs. but i think probably easy to remedy by adding maintainer to the config - we expect ot see strange plan outputs if none is defined
sloloris
reviewed
Jul 9, 2025
sloloris
approved these changes
Jul 9, 2025
Co-authored-by: Isabelle Miller <imiller@launchdarkly.com>
This was referenced Jul 9, 2025
This was referenced Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add LaunchDarkly Views Resource Support
Adds
Related Jira issue: REL-8140: Add View features to TF Provider