feat: migrate from Vite to rslib for bundling #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-packages-unified-build
- Replace Vite with rslib for both library and CDN builds - Add rslib.config.ts for NPM library build (ESM/CJS formats) - Add rslib.config.cdn.ts for CDN IIFE build with global exposure - Update package.json with rslib dependencies and new build scripts - Remove Vite-related dependencies and configurations - Implement Storybook integration with storybook-addon-rslib - Fix CSS injection for shadow DOM compatibility with rslib's injectStyles - Update mount.tsx to filter and copy toolbar styles to shadow DOM - Generate source maps for both library and CDN builds - Maintain backward compatibility for existing integrations
sub-ld
commented
Oct 13, 2025
| .join('\n'); | ||
|
|
||
| if (toolbarStyles) { | ||
| style.textContent = toolbarStyles; |
There was a problem hiding this comment.
VIte has special plugin which made the prev approach possible. RSLib doesn't have that so we're resorting to this verbose approach for now
…brary build - Remove VanillaExtractPlugin from library config (only needed for CDN build) - Library consumers handle their own CSS processing - CDN build still includes VanillaExtractPlugin for style bundling - Both builds maintain React plugin for JSX/TSX transformation
cspath1
approved these changes
Oct 13, 2025
Update Storybook to 9.1.10, resolving peer dependency issues Update @launchpad-ui packages
cspath1
approved these changes
Oct 13, 2025
Base automatically changed from
pjately/consolidate-packages-unified-build
to
cspath/REL-9841-toolbar-revamp
October 13, 2025 21:11
| "sideEffects": false, | ||
| "files": [ | ||
| "dist", | ||
| "cdn", |
There was a problem hiding this comment.
Was this intentional? @sub-ld The hook loads the toolbar from unpkg at /cdn/toolbar.min.js, which won't exist if cdn isn't published to npm.
There was a problem hiding this comment.
Ah I didnt realize that is how we host the cdn. Thanks I'll change this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Migration from Vite to rslib
This PR migrates the LaunchDarkly Toolbar from Vite to rslib for both library and CDN builds, providing better performance and more consistent bundling.
✅ What's Changed
Build System Migration
Storybook Integration
CSS & Shadow DOM Fixes
Build Outputs
📊 Bundle Analysis
🔧 Technical Details
🧪 Testing
📝 Migration Notes
This migration provides a more robust and performant build system while maintaining full backward compatibility.