fix: ensure E2E tests use Playwright mocks instead of MSW #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes failing E2E tests when running the server using pnpm demo:mock. This was because Playwright mocks were not overriding the values from MSW which resulted in failing tests.
There was a problem hiding this comment.
I've removed these and replaced them with the following:
const LD_BASE_URL = '**/sdk/evalx/**';
const LD_EVENT_STREAM_URL = '**/eval/**';
The change allows us to continue using the internal url when developing in our env vars and allows the requests to still be mocked by Playwright - which they would not otherwise since the domains did not match.
sub-ld
approved these changes
Oct 13, 2025
sub-ld
reviewed
Oct 13, 2025
| useMocks: import.meta.env.VITE_USE_MOCK_FLAGS === 'true', | ||
| // Use mocks if explicitly enabled via env var, but never during automated tests | ||
| // Automated tests (like Playwright) provide their own network mocking | ||
| useMocks: import.meta.env.VITE_USE_MOCK_FLAGS === 'true' && !isAutomatedTest(), |
There was a problem hiding this comment.
Note that this adds some "magic" which is happening in the demo app. It's not so obvious that Playwright relies on this as the logic is decoupled. Perhaps we can add a README.md to Playwright as a follow-up which describes the approach we've taken along with other basic info about our e2e testing strategy?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes E2E more robust.
What does this PR do?
Fixes failing E2E tests when running the server using pnpm demo:mock. This was because Playwright mocks were not overriding the values from MSW which resulted in failing tests.
Type of Change
Screenshots/Videos