Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: launchdarkly/js-core
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
Loading
...
head repository: launchdarkly/js-core
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ta/fdv2-temporary-holding
Choose a head ref
Loading
Checking mergeability… Don’t worry, you can still create the pull request.
  • 10 commits
  • 67 files changed
  • 2 contributors

Commits on Jan 22, 2025

  1. chore: preparation work for FDv2 feature store and persistence support (

    #725)
    
    Splitting these changes up into multiple PRs to keep them manageable and
    because we can't merge directly to main as `applyChanges` is dependent
    on transaction support in the PersistentDataStore.
    
    Existing tests are exercising applyChanges, but through init, upsert,
    and delete. Plan to add applyChanges tests in ta/fdv2-temporary-holding
    after transaction support is added to PersistentDataStore in a
    subsequent PR as part of SDK-1029
    tanderson-ld authored Jan 22, 2025
    Configuration menu
    Copy the full SHA
    179b199 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2025

  1. feat: adds fdv2 transactional persistent store (#747)

    **Related issues**
    
    SDK-1029
    
    **Describe the solution you've provided**
    
    Adds TransactionalPersistentStore containing memory store and
    persistence store. Swaps on basis being provided as necessary.
    
    Planning to add tests on holding branch (PR target branch).
    tanderson-ld authored Jan 27, 2025
    Configuration menu
    Copy the full SHA
    c2debf7 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2025

  1. chore: adding more FDv2 tests (#768)

    More tests for FDv2 branch
    tanderson-ld authored Feb 3, 2025
    Configuration menu
    Copy the full SHA
    5dbe832 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2025

  1. chore: adds CompositeDataSource for FDv2 support (#787)

    **Requirements**
    
    - [x] I have added test coverage for new or changed functionality
    
    - [x] I have followed the repository's [pull request submission
    guidelines](../blob/main/CONTRIBUTING.md#submitting-pull-requests)
    - [ ] I have validated my changes against all supported platform
    versions
    Will be done on target temp branch eventually.
    
    **Related issues**
    
    SDK-857
    tanderson-ld authored Mar 28, 2025
    Configuration menu
    Copy the full SHA
    d1d9e0f View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2025

  1. chore: Adds LDDataSystemOptions for configuring the Data System. (#794)

    **Requirements**
    
    - [x] I have added test coverage for new or changed functionality
    
    - [x] I have followed the repository's [pull request submission
    guidelines](../blob/main/CONTRIBUTING.md#submitting-pull-requests)
    - [ ] I have validated my changes against all supported platform
    versions
    Will be done on target temp branch eventually.
    
    **Related issues**
    
    SDK-857 and SDK-1073
    
    ---------
    
    Co-authored-by: Todd Anderson <tanderson@Todds-MacBook-Pro.local>
    tanderson-ld and Todd Anderson authored Apr 7, 2025
    Configuration menu
    Copy the full SHA
    e2c26af View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2025

  1. feat: adds polling synchronizer support (#816)

    **Requirements**
    
    - [x] I have added test coverage for new or changed functionality
    
    - [x] I have followed the repository's [pull request submission
    guidelines](../blob/main/CONTRIBUTING.md#submitting-pull-requests)
    - [ ] I have validated my changes against all supported platform
    versions
    This will be done at a later time on the target branch during
    integration testing.
    
    **Related issues**
    
    SDK-858 and SDK-851
    
    **Describe the solution you've provided**
    
    Refactors payload processing to be reusable between polling data sources
    and streaming data sources.
    Adds OneShotInitializers and PollingSynchronizer.
    Adds support to contract tests for sdk-test-harness/feat/fdv2 branch.
    
    ---------
    
    Co-authored-by: Todd Anderson <tanderson@Todds-MacBook-Pro.local>
    tanderson-ld and Todd Anderson authored Apr 11, 2025
    Configuration menu
    Copy the full SHA
    c1089a5 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2025

  1. feat: CompositeDataSource blacklists DataSources that report unrecove…

    …rable error (#826)
    
    **Requirements**
    
    - [x] I have added test coverage for new or changed functionality
    - [x] I have followed the repository's [pull request submission
    guidelines](../blob/main/CONTRIBUTING.md#submitting-pull-requests)
    - [ ] I have validated my changes against all supported platform
    versions
    To be done on target branch.
    
    ---------
    
    Co-authored-by: Todd Anderson <tanderson@Todds-MacBook-Pro.local>
    tanderson-ld and Todd Anderson authored Apr 22, 2025
    Configuration menu
    Copy the full SHA
    aee6479 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2025

  1. feat: falls back to FDv1 polling if flag delivery sends fallback head…

    …er (#832)
    
    **Requirements**
    
    - [x] I have added test coverage for new or changed functionality
    - [x] I have followed the repository's [pull request submission
    guidelines](../blob/main/CONTRIBUTING.md#submitting-pull-requests)
    - [ ] I have validated my changes against all supported platform
    versions
    Will validate on holding branch later.
    
    **Related issues**
    
    SDK-1179
    
    **Describe the solution you've provided**
    
    Adds FDv1 fallback error type. FDv2 datasources now report that error
    type if they see the fallback header from the FDv2 endpoints.
    
    Updates FDv2 polling datasource to support being constructed in a FDv1
    to FDv2 conversion mode. In that mode, the response from an FDv1
    endpoint will be converted to an FDv2 payload and passed through the
    FDv2 payloadProcessor.
    
    CompositeDataSource now supports an FDv1 fallback synchronizer list. If
    any datasource reports the FDv1 fallback error, the CompositeDataSource
    switches to use the fallback synchronizer list.
    
    This PR also contains tweaks to get the holding branch working with the
    latest contract tests that got some tweaks during recent integration
    testing.
    
    ---------
    
    Co-authored-by: Todd Anderson <tanderson@Todds-MacBook-Pro.local>
    tanderson-ld and Todd Anderson authored Apr 29, 2025
    Configuration menu
    Copy the full SHA
    063c778 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2025

  1. feat: now utilizes FDv2 basis param for more efficient polling (#843)

    **Requirements**
    
    - [x] I have added test coverage for new or changed functionality
    - [x] I have followed the repository's [pull request submission
    guidelines](../blob/main/CONTRIBUTING.md#submitting-pull-requests)
    - [ ] I have validated my changes against all supported platform
    versions
    Will be done on target branch in the future as part of integration
    testing.
    
    **Related issues**
    
    SDK-1044
    
    **Describe the solution you've provided**
    
    Pipes selector through datasource and feature store layers / APIs.
    InMemoryFeatureStore holds the selector in memory at runtime. When
    datasources need the selector for making their requests, they invoke a
    selectorGetter lambda that is hooked up to the InMemoryFeatureStore.
    
    ---------
    
    Co-authored-by: Todd Anderson <tanderson@Todds-MacBook-Pro.local>
    tanderson-ld and Todd Anderson authored May 9, 2025
    Configuration menu
    Copy the full SHA
    82f9ff1 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2025

  1. feat: now utilizes FDv2 basis param for streaming (#847)

    **Requirements**
    
    - [x] I have added test coverage for new or changed functionality
    - [x] I have followed the repository's [pull request submission
    guidelines](../blob/main/CONTRIBUTING.md#submitting-pull-requests)
    - [x] I have validated my changes against all supported platform
    versions
    
    **Related issues**
    
    SDK-1220
    
    Co-authored-by: Todd Anderson <tanderson@Todds-MacBook-Pro.local>
    tanderson-ld and Todd Anderson authored May 12, 2025
    Configuration menu
    Copy the full SHA
    b1d1bc6 View commit details
    Browse the repository at this point in the history
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.