Add OS and architecture to binary filename in CompileBinaryCommand #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the CompileBinaryCommand to include the operating system type and architecture in the binary filename. This change ensures that binaries are uniquely identified by their build environment, preventing potential conflicts when binaries for different environments are stored in the sa directory.
The OS type is now converted to lowercase to ensure consistency and prevent potential issues with case sensitivity during binary compilation. Th change helps maintain uniformity across different environments.
Updated the CompileBinaryCommand to standardize OS and architecture names. This ensures compatibility and consistency across different environments by mapping 'darwin' to 'mac', 'Linux' to 'linux', and 'Windows NT' to 'windows'. Similarly, 'x86_64' is mapped to 'x64' and 'aarch6 to 'arm64'. This change helps in generating binaries with a consistent naming convention.
|
Mappings have also been added to match Node.js OS architecture names and OS type names. |
|
An update for the OS has also been added: laravel/vs-code-extension#22 |
eznix86
reviewed
Dec 16, 2024
Updated the OS and architecture detection logic using PHP's match expression for improved readability and maintainability. This change simplifie the code by replacing multiple if-else statements with a more concise and expressive syntax, making it easier to understand and extend in the future.
|
@joetannenbaum I think you fixed the issue do I need to keep the PR |
|
@kpanuragh yeah it fixes it, it now works correctly on my intel, have you tested on yours too? cc @eznix86 |
|
@kpanuragh thank you for the PR! Ended up handling this a different way, but I appreciate you submitting this, going to close this one. |
joetannenbaum
added a commit
that referenced
this pull request
May 7, 2025
…tPhpParserNodeArrayElement$memberName-#1 Fix Undefined property: Microsoft\PhpParser\Node\ArrayElement::$memberName
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the CompileBinaryCommand to include the operating system type and architecture in the binary filename. This change ensures that binaries
are uniquely identified by their build environment, preventing potential conflicts when binaries for different environments are stored in the sa
directory.