Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Support for locale parameter in translations #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

N1ebieski
Copy link
Contributor

@N1ebieski N1ebieski commented Mar 12, 2025

This PR adds support for locale parameter in translations, for example:

__('validation.attributes.question', locale: 'pt_BR')

links to /lang/pt_BR/validation.php even though the default app.locale is en.

This code needs futher refactoring and testing.

@joetannenbaum
Copy link
Collaborator

Great stuff, thank you! Added autocompletion for locale params as well.

@joetannenbaum joetannenbaum merged commit 1964c64 into laravel:main Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.