Make the github test action run out of the box independent of the choice of testing framework #6555
Conversation
|
It doesn't matter much, because |
It does come along! I have created 3 projects by now (with the Herd New Project button) and every time it did come along. Resulting immediately in an email reporting failing action, as soon as I connected the repo to my Github account. |
|
It does not come along when you use e.g. The Line 9 in bd44e4a Seems Laravel Herd is doing something else. |
|
The starter kits don’t have the Possibly an oversight - would need to remove it from |
|
laravel/installer#401 |
Summary
This PR changes the test runner for the github action to
php artisan testWhy This Change?
The included github testing action executes
./vendor/bin/phpunitbut when pest is chosen, this results in an error.I know it's easy to fix (and the error message tells you exactly what to do, that is, run
./vendor/bin/pest), but wouldn't it be nicer if it would just work out of the box?Testing & Compatibility
No runtime behavior changes
Compatible with existing Laravel applications.