[12.x] collapseWithKeys - Prevent exception in base case #56002
Merged
+8
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
collapseWithKeys
method of Collections will throw an exception if the collection is already flat (i.e. none of the top level elements are arrays or collections).Before the changes in this PR:
After the changes in this PR:
This PR handles this case by returning an empty collection, similar to what
LazyCollection
does.This PR should be considered for merging because it allows
collapseWithKeys
to operate over a larger scope of potential inputs sensibly without causing exceptions to be thrown. The user ofcollapseWithKeys
should be able to use it on collections without having to check the structure of the collection first to prevent exceptions.Happy to make any adjustments, no hard feelings if closure.