[12.x] Fix division by zero when $perPage is 0 in LengthAwarePaginator
#55958
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$perPage is 0 in LengthAwarePaginator
|
GrahamCampbell
requested changes
Jun 9, 2025
|
@platoindebugmode pr a phpdoc change 'int' to 'positive-int' |
|
The framework does not use the |
|
yet |
|
It's a pretty explosive thing to add. You add it in one place, and then all the callers change, and all their callers, etc. Things will get very out of hand if we do this. I think we should not. |
|
You are not wrong with the first two sentences. I get it. It, however, would be right to add it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request prevents a potential division by zero error in the
LengthAwarePaginatorconstructor when$perPageis set to0. Instead of attempting to divide by zero, the code now defaults the last page to1in such cases.No breaking changes, fallback behavior is consistent with framework philosophy.
References
N/A – this was a direct edge case improvement.