Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[12.x] Fix incorrect return types and handle NumberFormatter failure in Number class #55957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: 12.x
Choose a base branch
Loading
from
Draft

[12.x] Fix incorrect return types and handle NumberFormatter failure in Number class #55957

wants to merge 1 commit into from

Conversation

platoindebugmode
Copy link
Contributor

This PR updates the Number class to:

  • Correct the return types of parse(), parseInt(), and parseFloat() to include false.
  • Add return types for spell(), ordinal(), and spellOrdinal() methods.
  • Handle false return values from NumberFormatter::format() by falling back to (string) $number.

No breaking changes introduced, only enhances type accuracy and guards against silent false values.

@shaedrich
Copy link
Contributor

Adding a return type hint is a breaking change. Therefore, you should target master

@taylorotwell taylorotwell marked this pull request as draft June 9, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@platoindebugmode @shaedrich
Morty Proxy This is a proxified and sanitized view of the page, visit original site.