[12.x] Fix incorrect return types and handle NumberFormatter failure in Number class #55957

platoindebugmode · Jun 8, 2025

This PR updates the Number class to:

Correct the return types of parse(), parseInt(), and parseFloat() to include false.
Add return types for spell(), ordinal(), and spellOrdinal() methods.
Handle false return values from NumberFormatter::format() by falling back to (string) $number.

No breaking changes introduced, only enhances type accuracy and guards against silent false values.

shaedrich · Jun 9, 2025

Adding a return type hint is a breaking change. Therefore, you should target master

add accurate return types and handle false from NumberFormatter

c45ae46

taylorotwell marked this pull request as draft June 9, 2025 14:09

platoindebugmode closed this by deleting the head repository Sep 20, 2025

Provide feedback