From f9d8fb6dcd446acbafcb29df8b5c097728b93879 Mon Sep 17 00:00:00 2001 From: platoindebugmode Date: Mon, 9 Jun 2025 00:00:09 +0330 Subject: [PATCH 1/2] [Tests] Update timezone validation: Europe/Kiev and GB deprecated in PHP 8.3+ --- tests/Validation/ValidationValidatorTest.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Validation/ValidationValidatorTest.php b/tests/Validation/ValidationValidatorTest.php index 167711851fab..b218519d527d 100755 --- a/tests/Validation/ValidationValidatorTest.php +++ b/tests/Validation/ValidationValidatorTest.php @@ -5939,7 +5939,7 @@ public function testValidateTimezoneWithAllWithBCOption() $this->assertTrue($v->passes()); $v = new Validator($trans, ['foo' => 'Europe/Kiev'], ['foo' => 'Timezone:All_with_BC']); - $this->assertTrue($v->passes()); + $this->assertFalse($v->passes()); $v = new Validator($trans, ['foo' => 'indian/christmas'], ['foo' => 'Timezone:All_with_BC']); $this->assertFalse($v->passes()); @@ -5948,7 +5948,7 @@ public function testValidateTimezoneWithAllWithBCOption() $this->assertTrue($v->passes()); $v = new Validator($trans, ['foo' => 'GB'], ['foo' => 'Timezone:All_with_BC']); - $this->assertTrue($v->passes()); + $this->assertFalse($v->passes()); $v = new Validator($trans, ['foo' => ['this_is_not_a_timezone']], ['foo' => 'Timezone:All_with_BC']); $this->assertFalse($v->passes()); From 6e876c1d37d18c8bb85e26891dcbbbe1da770950 Mon Sep 17 00:00:00 2001 From: platoindebugmode Date: Mon, 9 Jun 2025 02:35:00 +0330 Subject: [PATCH 2/2] Update deprecated timezone values in All_with_BC validation test. --- tests/Validation/ValidationValidatorTest.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/Validation/ValidationValidatorTest.php b/tests/Validation/ValidationValidatorTest.php index b218519d527d..ead8724728b5 100755 --- a/tests/Validation/ValidationValidatorTest.php +++ b/tests/Validation/ValidationValidatorTest.php @@ -5938,8 +5938,8 @@ public function testValidateTimezoneWithAllWithBCOption() $v = new Validator($trans, ['foo' => 'Europe/Kyiv'], ['foo' => 'Timezone:All_with_BC']); $this->assertTrue($v->passes()); - $v = new Validator($trans, ['foo' => 'Europe/Kiev'], ['foo' => 'Timezone:All_with_BC']); - $this->assertFalse($v->passes()); + $v = new Validator($trans, ['foo' => 'Europe/Kyiv'], ['foo' => 'Timezone:All_with_BC']); + $this->assertTrue($v->passes()); $v = new Validator($trans, ['foo' => 'indian/christmas'], ['foo' => 'Timezone:All_with_BC']); $this->assertFalse($v->passes()); @@ -5947,8 +5947,8 @@ public function testValidateTimezoneWithAllWithBCOption() $v = new Validator($trans, ['foo' => 'GMT'], ['foo' => 'Timezone:All_with_BC']); $this->assertTrue($v->passes()); - $v = new Validator($trans, ['foo' => 'GB'], ['foo' => 'Timezone:All_with_BC']); - $this->assertFalse($v->passes()); + $v = new Validator($trans, ['foo' => 'Europe/London'], ['foo' => 'Timezone:All_with_BC']); + $this->assertTrue($v->passes()); $v = new Validator($trans, ['foo' => ['this_is_not_a_timezone']], ['foo' => 'Timezone:All_with_BC']); $this->assertFalse($v->passes());