revert: #55939 #55943
Merged
revert: #55939 #55943
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree with the revert, the function clearly states it only accepts string, if at any point a |
|
The only way this could ever do something is when the class was extended and In all other situations, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
revert: #55939
The first cast is never reached, because
! str_contains($key, '::')would throw on$key = null.The other both casts would prevent PHP 8.4 from throwing on a real error (and are also never reached when called from within the class).
$keyshould never benullhere; it can only result in an undesired outcome.The author of the PR didn't explain what their issue is. The merged PR is, however, the wrong fix.
cc: @Khuthaily