[12.x] Restore lazy loading check #55817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@decadence , You are absolutely right! I had an N+1 issue with a package I'm using, and I thought it was something like a Laravel false-positive warning. @taylorotwell , I'm so sorry about that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #55771
I (and some other people) don't see much point in that change. If
automaticallyEagerLoadingRelationshipsis working correctly then the code will not reach this point. If it's wrong in some situations (packages or some complex cases) then we should see the exception but after that change we won't.automaticallyEagerLoadingRelationshipsworks withpreventLazyLoadingnicely so why do we need disable this check?