[12.x] Introduce Arr::from() #55715
Merged
[12.x] Introduce Arr::from() #55715
+171
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instances as scalars
shaedrich
reviewed
May 12, 2025
Why? |
I decided to distinguish between "casting to array" and "wrapping in array". I wanted to keep it simple without creating special case for enums where it should not belong (issue with enum was inability to adequately wrap it in array). |
You did! Thanks a lot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a second attempt at extracting
getArrayableItems()functionality into separate function (first PR).Key differences from previous PR are:
Arr::from()won't wrap scalar values to follow single responsibility principle;getArrayableItems- see [8.x] Handle collection creation around a single enum #42839);WeakMapinstances are now convertable into lists (keys cannot be preserved for obvious reasons);Arr::arrayable()helper function has been added to be used in pair withArr:from()when needed.As for
WeakMapconcern:I am convinced that this issue valid for both collections and arrays - arrays cannot be created with objects as a keys.
We can handle this situation by throwing an exception (current behavior) or by omitting
WeakMapkeys during casting to array (this PR).Let me know if you prefer to keep current behavior.