[12.x] Container currentlyResolving utility
#55684
Merged
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
db5cbb3 to
f6be612
Compare
|
First, the changes to the I added this test case on my local branch to the public function testCurrentlyResolving()
{
$container = new Container;
$container->afterResolvingAttribute(ContainerCurrentResolvingAttribute::class, function ($attr, $instance, $container) {
$this->assertEquals(ContainerCurrentResolvingConcrete::class, $container->currentlyResolving());
});
$container->when(ContainerCurrentResolvingConcrete::class)
->needs('$currentlyResolving')
->give(fn ($container) => $container->currentlyResolving());
$resolved = $container->make(ContainerCurrentResolvingConcrete::class);
$this->assertEquals(ContainerCurrentResolvingConcrete::class, $resolved->currentlyResolving);
}This would test both when an attribute is being resolved, and when a contextual binding is being resolved. At the end of this same file, I added these helpers classes: #[Attribute(Attribute::TARGET_PARAMETER)]
class ContainerCurrentResolvingAttribute implements ContextualAttribute
{
public function resolve()
{
}
}
class ContainerCurrentResolvingConcrete
{
public $currentlyResolving;
public function __construct(
#[ContainerCurrentResolvingAttribute]
string $currentlyResolving
)
{
$this->currentlyResolving = $currentlyResolving;
}
} |
|
Thanks @rodrigopedra! I'll add these tests and pull out the |
|
Oops, merged after reverting the interface change. @jrseliga can you send the test in another PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposing what the container is currently resolving would be a useful feature.
For example, given a server:
And a repository that holds registrations mapping a server to features:
We could have a Contextual Attribute responsible for returning the features registered specifically to a server instead of having to perform an operation on our
RegistrarThis PR provides access to what the container is currently resolving -- allowing:
Note: I was unsure the best way to test this since
Container::$buildStackis not modified untilContainer::build()is called which is after the before callbacks. The resolving item is also popped offContainer::$buildStackbefore the after callbacks.