[12.x] fix: intersect Authenticatable with Model in UserProvider phpdocs #54061
+15
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure why the contract would require an Eloquent model. 🤔 |
|
@taylorotwell, these are just docblock changes so not breaking (at the moment, eventually the method signature should be updated). Not all of the contract methods require a Model, but some do call Model methods and would failing if the intersection type is not guaranteed: framework/src/Illuminate/Auth/EloquentUserProvider.php Lines 86 to 104 in 8b93d39 Due to this, I just updated all of them for consistency, but I can remove the intersection from the methods that don't have to have it as a parameter. The method that particularly caused problems for me was |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This adds the
Modelintersection toAuthenticatabletypes (and visa versa) in the UserProvider phpdocs. This prevents redundant checks in user / package land to satisfy phpstan when calling methods that don't exist on the other type.Thanks!