Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[12.x] Add missing through() to pagination contracts #51638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

imcrizal
Copy link

Hello,

Although the current state will not produce any runtime errors, I want to stop our IDE from complaining about the Undefined method 'through' on Pagination. This will also allow us to jump to the function description.

Related issue:

@driesvints driesvints changed the title Add missing through() to pagination contracts [12.x] Add missing through() to pagination contracts May 30, 2024
@taylorotwell
Copy link
Member

Rather than add to the contract, can you just send a docblock for the contract method to the 11.x branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.