[12.x] Consider after_commit config in SyncQueue #51035
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's fine to send this to 11.x branch please. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AfterCommit support was added to the SyncQueue in #48860. However, it only works if the job in question implements the
ShouldQueueAfterCommitinterface or sets theafterCommitproperty - it does not work ifafter_commitis set to true in the sync driver's configuration. This makes the behavior inconsistent, which is what this PR intends to solve.I am adding it to the
masterbranch as I consider it a breaking change.I spent some time unsuccessfully trying to figure out how to write a test for this. If anyone has an idea, please let me know and I'll add a test.