[11.x] Add typed getters to session store #50342
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fixed the tests but I wonder if these could be more readable or more clean: public function testSessionTypedGettersWithWrongTypes(): void
{
$session = $this->getSession();
$session->getHandler()->shouldReceive('read')->once()->with($this->getSessionId())->andReturn(serialize([
'integer' => '12',
'array' => null,
'boolean' => 'true',
'float' => '12.34',
'string' => 12,
]));
$session->start();
$this->assertTypeError(fn () => $session->integer('integer'), 'integer');
$this->assertTypeError(fn () => $session->array('array'), 'array');
$this->assertTypeError(fn () => $session->boolean('boolean'), 'boolean');
$this->assertTypeError(fn () => $session->float('float'), 'float');
$this->assertTypeError(fn () => $session->string('string'), 'string');
}
private function assertTypeError(callable $callback, string $expectedType): void
{
try {
$callback();
$this->fail("Expected TypeError for $expectedType type.");
} catch (\TypeError $e) {
$this->assertMatchesRegularExpression("/Session value for key \[(.*)\] must be (.*) {$expectedType}, (.*) given./", $e->getMessage());
}
} |
|
I really am not sure this needs to propagate throughout the entire framework. 馃槵 Where else might this also apply? |
|
I don't know, I'm just figuring out when using the framework with static analysis (phpstan in my case) I let the core team decide whether or not it has to be a framework feature. I guess if not it can still be done via the extend method of the container 馃榿(package ?) |
|
Going to hold off on this for now I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 馃槃
I previously submitted a PR #50140 for typed configuration getters that have been approved and then enhanced by #50287.
I tried to make the same features for the session store as I believe it can help to have static analysis. Not sure though the way I wrote the tests.
Let me know if any changes needed (and also I didn't find a pint or lint command)
EDIT: Tests for type errors are not correct, changing to draft