Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit ed061e2

Browse filesBrowse files
authored
[12.x] Remove calls to optional() (#58027)
* remove optional * falsy check * last one * types
1 parent 607e835 commit ed061e2
Copy full SHA for ed061e2

File tree

Expand file treeCollapse file tree

3 files changed

+10
-4
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+10
-4
lines changed
Open diff view settings
Collapse file

‎src/Illuminate/Cache/DatabaseLock.php‎

Copy file name to clipboardExpand all lines: src/Illuminate/Cache/DatabaseLock.php
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,11 +137,11 @@ public function forceRelease()
137137
/**
138138
* Returns the owner value written into the driver for this lock.
139139
*
140-
* @return string
140+
* @return string|null
141141
*/
142142
protected function getCurrentOwner()
143143
{
144-
return optional($this->connection->table($this->table)->where('key', $this->name)->first())->owner;
144+
return $this->connection->table($this->table)->where('key', $this->name)->first()?->owner;
145145
}
146146

147147
/**
Collapse file

‎src/Illuminate/Http/Resources/Json/PaginatedResourceResponse.php‎

Copy file name to clipboardExpand all lines: src/Illuminate/Http/Resources/Json/PaginatedResourceResponse.php
+7-1Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,13 @@ public function toResponse($request)
2828
$this->resource->jsonOptions()
2929
), function ($response) use ($request) {
3030
$response->original = $this->resource->resource->map(function ($item) {
31-
return is_array($item) ? Arr::get($item, 'resource') : optional($item)->resource;
31+
if (is_array($item)) {
32+
return Arr::get($item, 'resource');
33+
} elseif (is_object($item)) {
34+
return $item->resource ?? null;
35+
}
36+
37+
return null;
3238
});
3339

3440
$this->resource->withResponse($request, $response);
Collapse file

‎src/Illuminate/Routing/UrlGenerator.php‎

Copy file name to clipboardExpand all lines: src/Illuminate/Routing/UrlGenerator.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -837,7 +837,7 @@ public function setRequest(Request $request)
837837
$this->cachedRoot = null;
838838
$this->cachedScheme = null;
839839

840-
tap(optional($this->routeGenerator)->defaultParameters ?: [], function ($defaults) {
840+
tap($this->routeGenerator?->defaultParameters ?: [], function ($defaults) {
841841
$this->routeGenerator = null;
842842

843843
if (! empty($defaults)) {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.