-
Notifications
You must be signed in to change notification settings - Fork 236
Fix env read bug for GCS_CREDENTIALS. #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
41tair
merged 1 commit into
langgenius:main
from
zhanluxianshen:fix-env-bug-for-GCS_CREDENTIALS
Jun 2, 2025
Merged
Fix env read bug for GCS_CREDENTIALS. #324
41tair
merged 1 commit into
langgenius:main
from
zhanluxianshen:fix-env-bug-for-GCS_CREDENTIALS
Jun 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhanluxianshen <zhanluxianshen@163.com>
longbingljw
pushed a commit
to oceanbase/dify-plugin-daemon
that referenced
this pull request
Sep 17, 2025
* fix: Fix the issue where the List method of Alibaba Cloud OSS did not correctly return plugin file paths. (langgenius#287) * feat(redis): Add support for Redis Sentinel mode (langgenius#276) * feat(redis): Add support for Redis Sentinel mode Added support for Redis Sentinel mode to the Redis client, enabling automatic discovery and connection to the primary node through Sentinel. Updated relevant configuration files and initialization logic to support Sentinel mode configuration and connection. * add lost RedisUser. * chore: coding style (langgenius#291) - Renamed parameters for consistency and clarity, changing `tenant_id`, `plugin_unique_identifier`, and `install_type` to `tenantId`, `pluginUniqueIdentifier`, and `installType` respectively across multiple functions. - Updated corresponding database queries to reflect the new parameter names, enhancing code readability and maintainability. * feat: Enhance plugin signing with authorized category verification (langgenius#293) * feat: Enhance plugin signing with authorized category verification - Added support for an `authorized_category` flag in the signature command to validate the category before signing. - Updated the `Sign` function to accept a verification parameter, allowing for category-based signing. - Enhanced error handling for invalid categories during the signing process. - Updated tests to cover new verification scenarios and ensure proper functionality with the authorized category. * fix * fix * test * test: Add unit test for plugin verification without verification field - Introduced a new test case to verify the behavior of plugins that lack a verification field. - Updated the signature_test.go file to include the test, ensuring proper functionality of the signing process. - Removed the outdated verifier_test.go file and associated test data to streamline the codebase. * Update issue templates * fix(lock): Add concurrency test for Redis lock functionality (langgenius#305) - Introduced a new test case `TestLock` to validate the behavior of the Redis locking mechanism under concurrent access. - Enhanced the `Lock` function to improve error handling and ensure proper locking behavior. - Utilized `sync.WaitGroup` and atomic operations to measure wait times during lock acquisition, ensuring the lock behaves as expected under high concurrency. * feat: Add code generation for plugin controllers and services (langgenius#301) * feat: Add code generation for plugin controllers and services - Introduced a code generation mechanism for plugin controllers and services, allowing for automatic generation based on defined dispatchers. - Created new files for generated controllers, services, and templates to streamline the plugin invocation process. - Removed outdated functions related to tool validation and runtime parameters, consolidating functionality into generated files. - Updated dependencies in go.mod and go.sum to include necessary packages for the new code generation features. * fix * feat: Generate HTTP server routes from template (langgenius#306) * feat: Generate HTTP server routes from template - Added a new file `http_server.gen.go` to automatically generate HTTP server routes based on defined dispatchers. - Refactored existing route definitions in `http_server.go` to utilize the generated routes, improving maintainability. - Introduced a code generation function in `generator.go` to create the HTTP server file, enhancing the plugin development workflow. - Updated the template for HTTP server generation to streamline route creation for various controllers. * fix: Update OAuth paths in PluginDispatchers for consistency - Changed the path for authorization URL from `/oauth/authorization_url` to `/oauth/get_authorization_url`. - Updated the path for credentials from `/oauth/credentials` to `/oauth/get_credentials` to align with naming conventions. * fix: errChan failed to write response because of panic nil (langgenius#296) (langgenius#297) * fix: errChan failed to write response because of panic nil (langgenius#296) * fix: join err and er into a single error using errors.Join, thanks @Yeuoly (langgenius#296) --------- Co-authored-by: NeatGuyCoding <cto@sb> * fix: signature dose not work as expected, if upload new pkg to old dify (langgenius#311) - Updated the method in the interface to remove the parameter, simplifying its usage. - Introduced a new function to provide a default verification structure. - Added a file to store verification data, improving the plugin signing process. - Enhanced tests in to validate the verification process, ensuring proper handling of success and failure scenarios. - Refactored related code to accommodate the new verification structure and improve overall maintainability. * feat: change listPlugin struct & add total (langgenius#302) * add packaged file info when plugin package larger than max size (langgenius#312) * refactor: streamline plugin initialization and update YAML templates for consistency (langgenius#313) - Removed redundant flag retrieval in the plugin initialization process, simplifying the code. - Updated permission handling to use a single `permissionRequirement` structure for better clarity and maintainability. - Enhanced YAML templates by adding quotes around dynamic values to ensure proper formatting and prevent potential parsing issues. * update issute template: add self checks * feat: add mcp tool type (langgenius#315) * Feat: Replace the internal/oss module with dify-cloud-kit (langgenius#317) * replace internal oss with dify-cloud-kit * remove validate * fix tests * fix tests * fix: support serverless plugin management with execution timeout (langgenius#318) - Added `pluginMaxExecutionTimeout` to `PluginManager` for configurable execution limits. - Updated `ServerlessPluginRuntime` to utilize the new timeout setting in HTTP requests. - Refactored AWSPluginRuntime references to ServerlessPluginRuntime for consistency across the codebase. * fix: remove redundant Content-Type header for payloadReader in HTTP request builder (langgenius#320) * Fix env read bug for GCS_CREDENTIALS. (langgenius#324) * fix build error, go.mod upgrade for github.com/panjf2000/ants/v2 (langgenius#323) Signed-off-by: zhanluxianshen <zhanluxianshen@163.com> * Chore/unify configurations (langgenius#319) * refactor: update PluginManager to use configuration for various configurations - Replaced hardcoded values in PluginManager methods with values from the configuration. - Updated serverless plugin launch timeout and working paths to utilize the new configuration structure. - Enhanced local plugin runtime initialization to pull settings from the configuration, improving maintainability and flexibility. * refactor: clean up PluginManager by removing unused fields and updating platform check - Removed commented-out fields from PluginManager to enhance code clarity. - Updated platform check to utilize the configuration structure instead of a direct field reference, improving maintainability. * feat: agent plugin add meta version * bump dify-cloud-kit version to 681efb7762a4 (langgenius#339) * add serverless runtime interface docs (langgenius#338) * add sri docs * add refer to readme * format readme * add USE_AWS_S3 args avoid ambiguity. (langgenius#340) * feat: add length-prefixed HTTP chunking functionality (langgenius#341) - Introduced new constants for HTTP option types to improve code readability and maintainability. - Updated existing HTTP option functions to utilize the new constants. - Implemented line-based and length-prefixed chunking methods for improved data processing in HTTP requests. - Added comprehensive tests for chunking functionality to ensure reliability and correctness. * refactor: using length-prefixed chunking for Backwards invocations (langgenius#342) - Adjusted the header byte manipulation in chunking functions to correctly use the first four bytes for data length. - Modified the HTTP request streaming function to include the length-prefixed option for improved data handling. * fix s3 client path style not used (langgenius#344) * bump cloud-kit version to fix langgenius#343 * change env name USE_AWS_S3 to S3_USE_AWS * update s3_use_aws default value to true * update readme about the upgrade notice * refactor(local_runtime): optimize listener lookup in stdioHolder (langgenius#345) Directly fetch and invoke the listener for a given session_id instead of iterating over the entire listener map. Signed-off-by: guanz42 <guanz42@163.com> * fix: skip waiting if error occured (langgenius#337) * fix: skip waiting if error occured * Update internal/core/plugin_manager/watcher.go Co-authored-by: Rhys <nghuutho74@gmail.com> * fix: handle nil error channels in plugin manager --------- Co-authored-by: Yeuoly <45712896+Yeuoly@users.noreply.github.com> Co-authored-by: Yeuoly <admin@srmxy.cn> * feat(db): enhance database configuration with charset and extras support (langgenius#347) - Updated .env.example to include DB_EXTRAS and DB_CHARSET variables. - Refactored InitPluginDB functions for PostgreSQL and MySQL to accept a configuration struct, allowing for more flexible database connection settings. - Adjusted connection pool settings to utilize new configuration options for charset and extras. This change improves the configurability of database connections and prepares the codebase for future enhancements. * feat: add decode plugin from identifier endpoint (langgenius#349) * feat: add decode plugin from identifier endpoint - Introduced a new endpoint to decode a plugin from a unique identifier. - Implemented the DecodePluginFromIdentifier function to handle decoding and verification of plugin signatures. - Updated the HTTP server routes to include the new decode endpoint. * refactor: update decode plugin endpoint path - Moved the decode plugin from identifier endpoint to a new path for better organization. - Updated the HTTP server routes accordingly to reflect the new endpoint structure. * Split REMOTE_INSTALL_ADDRESS into HOST and PORT in .env.example to align with the official docs (langgenius#356) Co-authored-by: lizb <lizb@sugon.com> * fix: launch error when using redis sentinel (langgenius#352) * refactor(plugin_manager): remove first logging of local plugin launch (langgenius#357) * refactor: extract DSN construction to buildDSN for better reuse and readability (langgenius#360) * fix:response data will be discard if tool/llm response buffer overflow (langgenius#362) Co-authored-by: kino.lu <kino.lu@vipshop.com> * test(stream): add delay in TestStreamCloseBlockingWrite to ensure blocking write completion (langgenius#365) * feat: add pull request template for improved contribution guidelines (langgenius#366) - Introduced a new pull request template to standardize contributions. - The template includes sections for description, type of change, essential checklist, and additional information to assist reviewers. * fix: prevent duplicate packaging (langgenius#367) fixes: langgenius/dify-plugins#612 fixes: langgenius/dify-plugins#234 Signed-off-by: jingfelix <jingfelix@outlook.com> * feat(dynamic_select): implement dynamic parameter fetching functionality (langgenius#358) * feat(dynamic_select): implement dynamic parameter fetching functionality - Added FetchDynamicParameterOptions function to handle dynamic parameter selection. - Introduced new access type and action for dynamic select in access_types. - Updated HTTP server routes to include the new endpoint for fetching dynamic parameters. - Created necessary service and controller files for dynamic select operations. * refactor(access_types): rename dynamic select access type to dynamic parameter - Updated access type constants to reflect the change from PLUGIN_ACCESS_TYPE_DYNAMIC_SELECT to PLUGIN_ACCESS_TYPE_DYNAMIC_PARAMETER. - Adjusted related references in the PluginDispatchers and FetchDynamicParameterOptions function to maintain consistency. * Update README.md (langgenius#372) * feat: add InvokeLLMWithStructuredOutput functionality (langgenius#369) * feat: add InvokeLLMWithStructuredOutput functionality - Introduced a new method InvokeLLMWithStructuredOutput to the BackwardsInvocation interface for handling structured output requests. - Added corresponding request and response types to support structured output. - Implemented the method in both RealBackwardsInvocation and MockedDifyInvocation for testing purposes. - Updated permission handling and task execution for the new structured output invocation type. This enhancement allows for more flexible and detailed responses from the LLM, improving the overall functionality of the invocation system. * refactor: enhance LLMResultChunkWithStructuredOutput structure - Updated the LLMResultChunkWithStructuredOutput type to include additional fields: Model, SystemFingerprint, and Delta. - Added comments to clarify the reasoning behind the structure and the use of type embedding for JSON marshaling. This change improves the clarity and functionality of the LLMResultChunkWithStructuredOutput type, ensuring proper JSON serialization. * refactor: streamline LLMResultChunk construction in InvokeLLMWithStructuredOutput - Simplified the construction of LLMResultChunk and LLMResultChunkWithStructuredOutput by removing unnecessary type embedding. - Enhanced readability and maintainability of the code while preserving functionality. This change contributes to cleaner code and improved clarity in the handling of structured output responses. * skip error plugin names (langgenius#381) * feat: add active request tracking to health check and dispatch routes (langgenius#384) - Implemented middleware to track active requests and active dispatch requests using atomic counters. - Updated health check response to include counts of active requests and active dispatch requests. - Integrated the new middleware into the HTTP server and plugin dispatch group for improved monitoring. * optimize: skip sleep for remote plugin runtime during restart, making the debugging experience smoother (langgenius#387) * enhance(cli/icon): add multiple categories default plugin icons (langgenius#388) * feat: add support for dark icon - Introduced IconDark field in PluginDeclaration and related structures to support dark mode icons. - Updated the installation process to handle dark icons. - Enhanced asset validation to check for the presence of dark icons. This change improves the visual consistency of plugins in dark mode environments. * enhance(cli/icon): add plugin icon support with multiple categories - Added support for light and dark icons for various plugin categories including agent, datasource, extension, model, tool, and trigger. - Replaced the previous single icon implementation with a structured map for better organization and retrieval of icons based on category and theme. - Removed the old Python icon file to streamline asset management. This update improves the visual representation of plugins across different themes, enhancing user experience. * change icons * fix * fix * comments * feat(plugin_manager): optimize local plugin startup with concurrency (langgenius#375) * feat(plugin_manager): optimize local plugin startup with concurrent control - Add semaphore-based concurrency control for plugin launches - Implement parallel plugin startup using goroutines - Optimize error handling to prevent goroutine blocking - Add concurrency metrics logging Note: handleNewLocalPlugins now accepts config parameter with default concurrency limit * feat(plugin_manager): make local plugin launching concurrency configurable * fix(plugin_manager): optimize comment and error handling - Updated comments to clarify the concurrent plugin launching configuration. - Added a nil check for the error channel during plugin startup to improve code robustness. * refactor(plugin_manager): refactor plugin startup logic - Remove the semaphore mechanism and switch to using routine.Submit for concurrency management * fix(plugin_manager): Optimize plugin startup logs and concurrency control - Added log output for maximum concurrency when starting local plugins - Implemented a channel-based concurrency control mechanism to ensure limits are not exceeded - Fixed closure variable capture issue to prevent incorrect plugin information - Improved error handling to avoid deadlocks during startup * fix(plugin_manager): simplify error channel handling and semaphore release logic --------- Co-authored-by: jim02.he <jim02.he@vipshop.com> * feat(plugin_manager): enhance asset remapping for icons (langgenius#392) - Refactored the RemapAssets function to streamline the remapping of icon fields for both models and tools, including support for dark mode icons. - Introduced new fields IconSmallDark and IconLargeDark in the ModelProviderDeclaration and added IconDark in ToolProviderIdentity to accommodate dark mode assets. - Improved error handling during the remapping process for better clarity and maintainability. * refactor(plugin_manager): enhance HTTP client timeout handling in ser… (langgenius#385) * refactor(plugin_manager): enhance HTTP client timeout handling in serverless runtime with DialContext - Updated the HTTP client in the ServerlessPluginRuntime to use a context-aware DialContext for better timeout management. - Removed the write timeout option from the HTTP request builder, streamlining the request handling process. - Improved connection handling by setting write deadlines based on the PluginMaxExecutionTimeout. This change enhances the reliability of network operations within the serverless runtime environment. * refactor(plugin_manager): remove write deadline setting in serverless runtime connection initialization - Eliminated the write deadline setting from the connection initialization in the ServerlessPluginRuntime. - This change simplifies the connection handling process and aligns with the recent enhancements to timeout management. This update contributes to a more streamlined and efficient network operation within the serverless environment. * refactor(plugin_manager): adjust HTTP client timeout settings in serverless runtime - Modified the HTTP client configuration in the ServerlessPluginRuntime to set the TLS handshake timeout based on PluginMaxExecutionTimeout. - Retained the IdleConnTimeout setting to ensure consistent connection management. This update improves the timeout handling for secure connections, enhancing overall network reliability in the serverless environment. * 0.2.0 (langgenius#402) * feat(oauth): add RedirectURI field to OAuth request structures * feat(oauth): update OAuthSchema validation * feat: add Context field to request and session structures * feat: add CredentialType field to Credentials and InvokeToolRequest structures * fix: handle unhandled default case in basic_type.go * feat: add support for build branches in build-push.yml * feat/tool oauth cli template (langgenius#407) * feat(cli): update OAuth handling and requirements for dify_plugin * feat(oauth): update OAuth support and adjust dify_plugin version constraints * feat(plugin_decoder): add support for internationalized readme files (langgenius#393) * feat(plugin_decoder): add support for internationalized readme files - Introduced the AvailableI18nReadme method in the PluginDecoder interface to retrieve available readme files in multiple languages. - Implemented the method in FSPluginDecoder and ZipPluginDecoder to read localized readme files from the filesystem and zip archives. - Enhanced UnixPluginDecoder to handle readme files in a structured manner, including support for reading from a dedicated "readme" directory. - Added unit tests to verify the functionality of the AvailableI18nReadme method and ensure correct retrieval of localized readme content. * feat(plugin): add support for multilingual README generation - Introduced functionality to create README files in multiple languages (Simplified Chinese, Japanese, Portuguese) based on user selection. - Enhanced the profile management to include options for enabling internationalized README and selecting languages. - Added new language choice structure to manage language options and their selection state. - Implemented rendering and writing of language-specific README files during plugin creation. - Included new README template files for each supported language. * feat(plugin): add README command and list functionality - Introduced a new `readme` command to the plugin CLI for managing README files. - Added `list` subcommand to display available README languages for a specified plugin path. - Implemented functionality to read and list supported README languages in a tabular format. - Enhanced error handling for plugin file reading and decoding processes. * feat(oauth): implement refresh credentials functionality (langgenius#408) * feat(oauth): implement refresh credentials functionality - Added RefreshCredentials endpoint to handle OAuth credential refresh requests. - Introduced RequestOAuthRefreshCredentials structure for request validation. - Updated access types and actions to include refresh credentials. - Enhanced server routing and controller logic to support the new functionality. - Updated OAuth entities to include expiration handling for refreshed credentials. * feat(oauth): add metadata field to OAuthGetCredentialsResult --------- Co-authored-by: Harry <xh001x@hotmail.com> * chore(deps): bump github.com/go-jose/go-jose/v4 from 4.0.4 to 4.0.5 (langgenius#409) Bumps [github.com/go-jose/go-jose/v4](https://github.com/go-jose/go-jose) from 4.0.4 to 4.0.5. - [Release notes](https://github.com/go-jose/go-jose/releases) - [Commits](go-jose/go-jose@v4.0.4...v4.0.5) --- updated-dependencies: - dependency-name: github.com/go-jose/go-jose/v4 dependency-version: 4.0.5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: MySQL compatible Dify plugin daemon based on https://github.com/langgenius/dify-plugin-daemon/releases/tag/0.2.0 --------- Signed-off-by: zhanluxianshen <zhanluxianshen@163.com> Signed-off-by: guanz42 <guanz42@163.com> Signed-off-by: jingfelix <jingfelix@outlook.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: bravomark <62681807+bravomark@users.noreply.github.com> Co-authored-by: Zhi <erigocn@gmail.com> Co-authored-by: Yeuoly <45712896+Yeuoly@users.noreply.github.com> Co-authored-by: Byron.wang <altair96wby@gmail.com> Co-authored-by: NeatGuyCoding <15627489+NeatGuyCoding@users.noreply.github.com> Co-authored-by: NeatGuyCoding <cto@sb> Co-authored-by: Good Wood <slm_1990@126.com> Co-authored-by: Byron.wang <byron@dify.ai> Co-authored-by: Novice <novice12185727@gmail.com> Co-authored-by: 湛露先生 <zhanluxianshen@163.com> Co-authored-by: Nevermore <guanz42@163.com> Co-authored-by: Rhys <nghuutho74@gmail.com> Co-authored-by: Yeuoly <admin@srmxy.cn> Co-authored-by: Ganondorf <364776488@qq.com> Co-authored-by: lizb <lizb@sugon.com> Co-authored-by: Tsonglew <tsonglew@gmail.com> Co-authored-by: kinoooolu <kinoooolu@gmail.com> Co-authored-by: kino.lu <kino.lu@vipshop.com> Co-authored-by: Tianyi Jing <jingfelix@outlook.com> Co-authored-by: @defstream <63482+defstream@users.noreply.github.com> Co-authored-by: AkisAya <akikevinsama@gmail.com> Co-authored-by: Blackoutta <37723456+Blackoutta@users.noreply.github.com> Co-authored-by: homejim <454690042@qq.com> Co-authored-by: jim02.he <jim02.he@vipshop.com> Co-authored-by: Maries <xh001x@hotmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.