fix(environments): correctly propagate client attribute #1188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add
environment
attribute propagation to span and generation methods inclient.py
andspan.py
.environment
attribute propagation instart_span()
,start_as_current_span()
,_start_as_current_otel_span_with_processed_media()
,update_current_span()
, andupdate_current_trace()
inclient.py
.environment
attribute toLangfuseSpan
andLangfuseGeneration
constructors inspan.py
.LangfuseSpan
andLangfuseGeneration
now includeenvironment
in their initialization and attribute setting.span.py
to includeenvironment
parameter.This description was created by
for 541b2c0. You can customize this summary. It will automatically update as commits are pushed.
Greptile Summary
Disclaimer: Experimental PR review
This PR fixes environment attribute propagation in the Langfuse Python client by ensuring proper environment context handling throughout the tracing system.
environment
parameter toLangfuseSpanWrapper
constructor inlangfuse/_client/span.py
to initialize environment contextlangfuse/_client/client.py
to pass environment attribute to child spansLangfuseSpanWrapper
when provided to ensure proper tracking