feat(client): allow more params.(like langfuse_version, etc) #1165
Conversation
There was a problem hiding this comment.
1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
0b4f495 to
04fb8bd
Compare
There was a problem hiding this comment.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
1b95ebb to
465b18d
Compare
|
@XenoAmess Thanks for raising this! As per our contributing guide, could you please open a Github issue / discussion first to lay out your line of thinking for this change to continue the discussion there on why this should be merged / this feature is necessary? |
|
465b18d to
f8fcb4f
Compare
Important
Enhance
on_chain_startinlangchain.pyto dynamically update trace-level parameters using metadata prefixed withlangfuse_.on_chain_startinlangchain.py, trace-level information is updated with metadata keys prefixed bylangfuse_.session_idanduser_idbased on metadata.update_dictfor updating trace information.This description was created by
for 0b4f495. It will automatically update as commits are pushed.
Greptile Summary
Disclaimer: Experimental PR review
Added support for dynamic trace parameter updates through metadata prefixing in the langchain callback handler, but introduced a bug that breaks existing functionality.
on_chain_startwheresession_idanduser_idare incorrectly set to None instead of using metadata valueslangfuse_prefixed metadata keysThe main issue is that the current implementation always sets
session_idanduser_idto None in theupdate_dict, overriding any values that may have been set in metadata. This needs to be fixed to preserve the existing functionality while adding support for the new dynamic parameters.💡 (2/5) Greptile learns from your feedback when you react with 👍/👎!