fix(cost-tracking): handle none values in OpenAI schema #1152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
19 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
langfuse/api/resources/annotation_queues/types/annotation_queue_object_type.py
Show resolved
Hide resolved
langfuse/api/resources/annotation_queues/types/create_annotation_queue_item_request.py
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add annotation queue handling and update OpenAI schema to handle
Nonevalues in token details.AnnotationQueuesClientandAsyncAnnotationQueuesClientinclient.py.AnnotationQueue,AnnotationQueueItem,AnnotationQueueObjectType,AnnotationQueueStatus,CreateAnnotationQueueItemRequest,DeleteAnnotationQueueItemResponse,PaginatedAnnotationQueueItems,PaginatedAnnotationQueues,UpdateAnnotationQueueItemRequest.README.mdandreference.mdwith usage examples for new annotation queue methods.OpenAiCompletionUsageSchemaandOpenAiResponseUsageSchemato handleNonevalues in token details.__init__.pyfiles to include new annotation queue types.This description was created by
for db7b2f1. It will automatically update as commits are pushed.
Greptile Summary
Disclaimer: Experimental PR review
This PR adds annotation queue functionality and fixes OpenAI usage schema to handle null values in token details, improving cost tracking accuracy and data handling capabilities.
/langfuse/api/resources/annotation_queues/with client implementations, models, and typesOpenAiResponseUsageSchemaandOpenAiCompletionUsageSchemain/langfuse/api/resources/ingestion/types/to handle optional token detailsAnnotationQueueandAnnotationQueueItemPydantic models with proper null handling and datetime serializationAnnotationQueueObjectTypeandAnnotationQueueStatusfor type-safe queue item handling/langfuse/api/reference.mdwith detailed examples and parameter specifications