fix: Respect eventActions filter in prompt version triggers #9659
+188
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where webhooks configured to trigger only on specific actions (e.g., "created", "deleted") were incorrectly being triggered by all actions including "updated" events. The processor now properly checks if the event action is in the trigger's eventActions array before executing. Closes langfuse#9630 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
Twill seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
| expect(executions).toHaveLength(0); | ||
| }); | ||
|
|
||
| it("should not execute when event action is not in trigger's eventActions array", async () => { |
There was a problem hiding this comment.
The added tests for eventActions filtering are comprehensive. To reduce duplication, consider abstracting common trigger/action creation logic into helper functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Respect eventActions filter in prompt version triggers
Fixes # #9630
Type of change
Mandatory Tasks
Important
Fixes bug in
promptVersionProcessorto respecteventActionsfilter, with new tests added.promptVersionProcessornow checks ifevent.actionis intrigger.eventActionsbefore processing inpromptVersionProcessor.ts.promptVersionProcessor.test.tsto verify correct behavior whenevent.actionis included or not intrigger.eventActions.event.actionis not intrigger.eventActions.event.actionis intrigger.eventActions.This description was created by
for 900515d. You can customize this summary. It will automatically update as commits are pushed.