fix(pydantic-ai): tool call mapping in OtelIngestionProcessor #9524
+31
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This fix addresses issue langfuse#9287 by adding support for pydantic-ai specific fields in OtelIngestionProcessor. Based on enhanced context analysis that included: - Related Issue langfuse#5515: Original discussion about tool call mapping - Related PR langfuse#9074: Add support for OpenAI tool calls (merged) - Related PR langfuse#8813: Related implementation patterns (merged) - Official Documentation: https://langfuse.com/integrations/frameworks/pydantic-ai Changes Made: - Add tool_arguments → input mapping in OtelIngestionProcessor.ts - Add tool_response → output mapping in OtelIngestionProcessor.ts - Add comprehensive test coverage for pydantic-ai field mapping - Maintain proper priority order in mapping chain The solution follows established patterns from related PRs and maintainer guidance from the referenced discussions. 🤖 Generated with Enhanced AI Developer Agent Co-Authored-By: Claude <noreply@anthropic.com>
c07adac to
37974e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue #9287 where pydantic-ai tool calls were showing null input/output in the Langfuse UI.
Changes Made
tool_argumentsandtool_responsein theextractInputAndOutput()methodtool_arguments→ observationinputtool_response→ observationoutputotelMapping.servertest.tsto verify the new mapping functionalityTechnical Details
The fix adds pydantic-ai field mapping after the generic input/output mapping but before GCP Vertex Agent mapping, maintaining the proper priority chain:
Test Coverage
tool_argumentstoinputcorrectlytool_responsetooutputcorrectlyRelated Issue
Closes #9287
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com
Important
Fixes pydantic-ai tool call mapping in
OtelIngestionProcessorto correctly maptool_argumentsandtool_responseto input and output.OtelIngestionProcessorby adding support fortool_argumentsandtool_responseinextractInputAndOutput().tool_argumentstoinputandtool_responsetooutput.otelMapping.servertest.tsto verify mapping oftool_argumentsandtool_response.This description was created by
for c07adac. You can customize this summary. It will automatically update as commits are pushed.