fix(python): allow _rowid in Permutation.select_columns#3277
Open
Zelys-DFKH wants to merge 1 commit intolancedb:mainlancedb/lancedb:mainfrom
Zelys-DFKH:fix/permutation-rowid-selectionZelys-DFKH/lancedb:fix/permutation-rowid-selectionCopy head branch name to clipboard
Open
fix(python): allow _rowid in Permutation.select_columns#3277Zelys-DFKH wants to merge 1 commit intolancedb:mainlancedb/lancedb:mainfrom Zelys-DFKH:fix/permutation-rowid-selectionZelys-DFKH/lancedb:fix/permutation-rowid-selectionCopy head branch name to clipboard
Zelys-DFKH wants to merge 1 commit intolancedb:mainlancedb/lancedb:mainfrom
Zelys-DFKH:fix/permutation-rowid-selectionZelys-DFKH/lancedb:fix/permutation-rowid-selectionCopy head branch name to clipboard
Conversation
`_rowid` is a virtual column emitted by the Rust PermutationReader but not present in the Arrow schema. Because `select_columns` built its allowed set from schema names only, requesting `_rowid` always raised a ValueError even though the Rust layer handles it correctly. Fixes lancedb#3132
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Permutation.select_columns(["_rowid", ...])raised aValueErrorbecause the Python validation layer built its allowed set from Arrow schema names, and_rowidis a virtual column not present in the schema.The Rust
PermutationReaderalready handles_rowidselection viahas_row_id(). The fix treats_rowidas a special case inselect_columnsand passes it through directly.Changes
python/python/lancedb/permutation.py: skip the schema lookup for_rowidinselect_columnspython/python/tests/test_permutation.py: addtest_select_columns_rowidcovering["_rowid", "id"]and["_rowid"]aloneRelated
Fixes #3132