Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[1.20.4] Ref: Remove NeoForge support#66

Merged
emyfops merged 2 commits into
masterlambda-client/lambda:masterfrom
remove-neoforge-supportlambda-client/lambda:remove-neoforge-supportCopy head branch name to clipboard
Aug 27, 2024
Merged

[1.20.4] Ref: Remove NeoForge support#66
emyfops merged 2 commits into
masterlambda-client/lambda:masterfrom
remove-neoforge-supportlambda-client/lambda:remove-neoforge-supportCopy head branch name to clipboard

Conversation

@emyfops

@emyfops emyfops commented Aug 26, 2024

Copy link
Copy Markdown
Collaborator

After thoroughly debugging reflections issues in NeoForge, the maintainer Orion confirmed that the uri scheme is incompatible with org.reflections.
There are no way to have platform independent reflections utils if we have NeoForge in our project.

Closes #37, closes #38

@github-actions github-actions Bot added the triage Requires labelling or review label Aug 26, 2024

@Avanatiker Avanatiker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your research!

@Avanatiker Avanatiker changed the title Remove NeoForge support [1.20.x] [NeoForge]: Remove NeoForge support Aug 27, 2024
@emyfops emyfops merged commit 1e9755c into master Aug 27, 2024
@emyfops emyfops deleted the remove-neoforge-support branch August 27, 2024 00:20
@emyfops emyfops changed the title [1.20.x] [NeoForge]: Remove NeoForge support [1.20.4] [NeoForge]: Remove NeoForge support Jan 8, 2025
@emyfops emyfops added 1.20 refactor and removed triage Requires labelling or review labels Jan 8, 2025
@emyfops emyfops changed the title [1.20.4] [NeoForge]: Remove NeoForge support [1.20.4] Ref: Remove NeoForge support Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[1.20.x] [NeoForge] Commands not registered [1.20.x] [NeoForge] Reflections fails to resolve VFSs

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.