This repository was archived by the owner on Jan 15, 2023. It is now read-only.
Enables Use of .NET Global Tools in Build Image#156
Merged
mhart merged 1 commit intolambci:masterlambci/docker-lambda:masterfrom May 17, 2019
chrisoverzero:feature/dotnet-global-toolsCopy head branch name to clipboard
Merged
Enables Use of .NET Global Tools in Build Image#156mhart merged 1 commit intolambci:masterlambci/docker-lambda:masterfrom chrisoverzero:feature/dotnet-global-toolsCopy head branch name to clipboard
mhart merged 1 commit intolambci:masterlambci/docker-lambda:masterfrom
chrisoverzero:feature/dotnet-global-toolsCopy head branch name to clipboard
Conversation
chrisoverzero
commented
Jan 9, 2019
Tools currently can't find `dotnet` because it's installed in a nonstandard location. The environment variable `DOTNET_ROOT` tells tools where to look. This and adding the tools path to `PATH` enables use of .NET Global Tools.
Contributor
Author
|
This PR accumulated some merge conflicts, which I've resolved. |
Member
|
Nice, I like this, thanks! I'd actually be ok with adding |
Member
|
Will let you know when I've built and pushed the new image |
Member
|
Having some issues with the way the PATH has changed actually, the Dockerfile won't build for me. Will need to make some changes. |
Contributor
Author
|
Oh, I must've botched the rebase, ugh. Apologies. First two meaningful lines should be: ENV DOTNET_ROOT=/var/lang/bin
ENV PATH=$DOTNET_ROOT:~/.dotnet/tools:$PATH \Would you like another PR from me for that, or is it trivial enough to copy-paste from here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the environment variable
DOTNET_ROOTand the tools path enables use of .NET Global Tools.Most useful is the
Amazon.Lambda.Toolsglobal tool, enabling commands beginning withdotnet lambda, such asdotnet lambda package. I considered installing this tool by default, but decided it may be too aggressive. If that sounds desirable, I can add another commit to this PR.