fix build constraint go1.8 #993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go1.8 wasn't properly excluded
Codecov Report
@@ Coverage Diff @@
## master #993 +/- ##
==========================================
- Coverage 76.56% 76.39% -0.18%
==========================================
Files 27 25 -2
Lines 2219 2207 -12
==========================================
- Hits 1699 1686 -13
Misses 398 398
- Partials 122 123 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #993 +/- ##
=======================================
Coverage 76.56% 76.56%
=======================================
Files 27 27
Lines 2219 2219
=======================================
Hits 1699 1699
Misses 398 398
Partials 122 122
Continue to review full report at Codecov.
|
Member
|
@jro7 thanks for your contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go1.8 wasn't properly excluded
https://golang.org/pkg/go/build/#hdr-Build_Constraints
Should also fix this GAE error: https://forum.labstack.com/t/undefined-pathunescape/256