Fix parameter routes with an extension (/foo/:id.json) #1106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up to #1101. It turns out that that patch is incomplete, as a similar check also needs to be added in the `Router.Add()` method. I don't understand why the test works fine, but when using it in a real application. For example with this example: func main() { e := echo.New() e.GET("/xxx/:id.json", func(c echo.Context) error { return c.String(200, fmt.Sprintf("%#v: names: %#v; vals: %#v", c.Path(), c.ParamNames(), c.ParamValues())) }) log.Fatal(e.Start(":8000")) } Gives a 404 on `/xxx/42.json`, and for `/xxx/42` it gives the output: /xxx/:id.json": names: []string{"id.json"}; vals: []string{"42"} It makes sense to add the test there too; I just don't get why the test cases that I added in ##1101 *does* produce the correct output :-/
Codecov Report
@@ Coverage Diff @@
## master #1106 +/- ##
=======================================
Coverage 81.14% 81.14%
=======================================
Files 25 25
Lines 1899 1899
=======================================
Hits 1541 1541
Misses 250 250
Partials 108 108
Continue to review full report at Codecov.
|
This was referenced Apr 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #1101. It turns out that that patch is
incomplete, as a similar check also needs to be added in the
Router.Add()method.I don't understand why the test works fine, but when using it in a real
application. For example with this example:
Gives a 404 on
/xxx/42.json, and for/xxx/42it gives the output:It makes sense to add the test there too; I just don't get why the test
cases that I added in ##1101 does produce the correct output :-/