From 42883c77dbe2b1cf09a30b67e9aca4d138f9154d Mon Sep 17 00:00:00 2001 From: Evgeniy Kulikov Date: Wed, 21 Feb 2018 21:59:40 +0300 Subject: [PATCH 1/2] [FIX] We must close gzip.Reader, only if no error --- middleware/compress_test.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/middleware/compress_test.go b/middleware/compress_test.go index ece13bd6d..6e36377a3 100644 --- a/middleware/compress_test.go +++ b/middleware/compress_test.go @@ -89,7 +89,9 @@ func TestGzipWithStatic(t *testing.T) { assert.Equal(t, cl, rec.Body.Len()) } r, err := gzip.NewReader(rec.Body) - assert.NoError(t, err) + if !assert.NoError(t, err) { + t.FailNow() + } defer r.Close() want, err := ioutil.ReadFile("../_fixture/images/walle.png") if assert.NoError(t, err) { From 4c8504590b549a6d8ae5fcebb27fe89b93d72138 Mon Sep 17 00:00:00 2001 From: Evgeniy Kulikov Date: Fri, 23 Feb 2018 22:30:28 +0300 Subject: [PATCH 2/2] review comments fix --- middleware/compress_test.go | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/middleware/compress_test.go b/middleware/compress_test.go index 6e36377a3..ff2a99327 100644 --- a/middleware/compress_test.go +++ b/middleware/compress_test.go @@ -89,14 +89,13 @@ func TestGzipWithStatic(t *testing.T) { assert.Equal(t, cl, rec.Body.Len()) } r, err := gzip.NewReader(rec.Body) - if !assert.NoError(t, err) { - t.FailNow() - } - defer r.Close() - want, err := ioutil.ReadFile("../_fixture/images/walle.png") if assert.NoError(t, err) { - var buf bytes.Buffer - buf.ReadFrom(r) - assert.Equal(t, want, buf.Bytes()) + defer r.Close() + want, err := ioutil.ReadFile("../_fixture/images/walle.png") + if assert.NoError(t, err) { + var buf bytes.Buffer + buf.ReadFrom(r) + assert.Equal(t, want, buf.Bytes()) + } } }