DRY'ed the redirect middleware tests a little #1055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1055 +/- ##
=======================================
Coverage 78.83% 78.83%
=======================================
Files 27 27
Lines 1885 1885
=======================================
Hits 1486 1486
Misses 284 284
Partials 115 115Continue to review full report at Codecov.
|
alexaandru
commented
Jan 30, 2018
middleware/redirect_test.go
Outdated
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| type redirectFunc func() echo.MiddlewareFunc |
Contributor
Author
There was a problem hiding this comment.
This is probably not the best name for this type, as it's nothing specific to redirect, it's just a function that returns a middleware (and all middleware "generators" do this). Is there a type for this already? If not what should we call it? middlewareGen ? middlewareConstructor ? ...
Contributor
Author
There was a problem hiding this comment.
Thanks @vishr middlewareGenerator it is then :)
vishr
pushed a commit
that referenced
this pull request
Mar 12, 2018
Enhancements:
Implemented Response#After()
Dynamically add/remove proxy targets
Rewrite rules for proxy middleware
Add ability to extract key from a form field
Implemented rewrite middleware
Adds a separate flag for the 'http/https server started on' message (#1043)
Applied a little DRY to the redirect middleware (#1053) and tests (#1055)
Simplify dep fetching (#1062)
Add custom time stamp format #1046 (#1066)
Update property name & default value & comment about custom logger
Add X-Requested-With header constant
Return error of context.File in c.contentDisposition
Updated deps
Updated README.md
Fixes:
Fixed Response#Before()
Fixed #990
Fix href url from armor to echo (#1051)
Fixed #1054
Fixed #1052, dropped param alias feature
Avoid redirect loop in HTTPSRedirect middleware (#1058)
Fix deferring body close in middleware/compress test (#1063)
Cleanup code (#1061)
FIX - We must close gzip.Reader, only if no error (#1069)
Fix formatting (#1071)
Can be a fix for auto TLS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.