Update instances of ’ char(8217) to ' char(39)#25
Closed
gregdotca wants to merge 1 commit intokyclark:masterkyclark/tiny_python_projects:masterfrom
Closed
Update instances of ’ char(8217) to ' char(39)#25gregdotca wants to merge 1 commit intokyclark:masterkyclark/tiny_python_projects:masterfrom
gregdotca wants to merge 1 commit intokyclark:masterkyclark/tiny_python_projects:masterfrom
Conversation
The inputs/sonnet-29.txt file was using a non-standard apostrophe, which could potentially cause some issues with readers' regex patterns.
Owner
|
Thank you for the suggestion. I finally fixed this! |
Author
|
For future reference, if you want to encourage users to contribute it's best to not close pull requests and then implement the exact changes yourself directly. To be honest I was quite happy to able to contribute to a project that I love, so it was a bit disappointing to see my pull request closed only to see the exact same changes popup in the code anyways. |
Owner
|
My apologies. I wasn't sure how to merge the PR, and I must have been too lazy to figure it out. I'll try to do better next time. I really do appreciate your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inputs/sonnet-29.txt file is using a non-standard apostrophe, which could potentially cause some issues with readers' regex patterns. This generally happens if text is brought in from somewhere with a non-standard character set, like an MS word doc or something similar.