Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix OWNERS file : reviewer to reviewers#2103

Merged
k8s-ci-robot merged 1 commit intokubernetes-client:masterkubernetes-client/java:masterfrom
Garima-Negi:fix-OWNERS-fileGarima-Negi/java:fix-OWNERS-fileCopy head branch name to clipboard
Jan 26, 2022
Merged

Fix OWNERS file : reviewer to reviewers#2103
k8s-ci-robot merged 1 commit intokubernetes-client:masterkubernetes-client/java:masterfrom
Garima-Negi:fix-OWNERS-fileGarima-Negi/java:fix-OWNERS-fileCopy head branch name to clipboard

Conversation

@Garima-Negi
Copy link
Contributor

@Garima-Negi Garima-Negi commented Jan 23, 2022

This PR solves Issue kubernetes/community#6334

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 23, 2022

Welcome @Garima-Negi!

It looks like this is your first PR to kubernetes-client/java 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/java has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 23, 2022
@dims
Copy link

dims commented Jan 24, 2022

@brendandburns @yue9944882 - a quick one liner fix in the root OWNERS file. Can you please approve/lgtm?

@brendandburns
Copy link
Contributor

brendandburns commented Jan 26, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, Garima-Negi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2022
@k8s-ci-robot k8s-ci-robot merged commit c68e136 into kubernetes-client:master Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@yue9944882 yue9944882 Awaiting requested review from yue9944882

Assignees

@brendandburns brendandburns

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Garima-Negi @k8s-ci-robot @dims @brendandburns
Morty Proxy This is a proxified and sanitized view of the page, visit original site.