Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix some typos in [en] docs. #43961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2023
Merged

Fix some typos in [en] docs. #43961

merged 1 commit into from
Nov 18, 2023

Conversation

yanggangtony
Copy link

This pr is fix some tiny typos.

likes

1 Config Maps --> ConfigMaps
2 liveleness --> liveness

Fix some typos in [en] docs.
5f3f34b 
Signed-off-by: yanggang <gang.yang@daocloud.io>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 16, 2023
@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 16, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 16, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 5f3f34b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65556446edecfc00081e4d35
😎 Deploy Preview https://deploy-preview-43961--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tengqm
Copy link
Contributor

tengqm commented Nov 16, 2023

In general, we don't fix blogs that are older than one year.
In this case, it is a typo fix, which is fine.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bf478eace4fc6096d82bbce5e72e643b88a1f106

kundan2707
kundan2707 reviewed Nov 16, 2023
View reviewed changes
Copy link
Contributor

@kundan2707 kundan2707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

divya-mohan0209
divya-mohan0209 reviewed Nov 18, 2023
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, we have a policy of not maintaining blog posts aged > 1 year unless explicitly mentioned. Additionally, we have a trivial edit policy that categorizes spelling/case changes as minor edits that do not add overall value.

On behalf of all SIG Docs approvers and reviewers, I'd request you to keep this in mind next time while submitting the PR since these add to manual overload.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divya-mohan0209

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2023
@k8s-ci-robot k8s-ci-robot merged commit eb18575 into kubernetes:main Nov 18, 2023
@yanggangtony yanggangtony deleted the fix-some-typos branch November 19, 2023 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@divya-mohan0209 divya-mohan0209 divya-mohan0209 left review comments

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@dipesh-rawat dipesh-rawat Awaiting requested review from dipesh-rawat

+1 more reviewer

@kundan2707 kundan2707 kundan2707 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@tengqm tengqm

@kundan2707 kundan2707

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yanggangtony @tengqm @k8s-ci-robot @divya-mohan0209 @kundan2707
Morty Proxy This is a proxified and sanitized view of the page, visit original site.