Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[v1.16] Update github.com/evanphx/json-patch to e83c0a1c26c884f8ec4fb743f6db92a941f605f1 #92455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[v1.16] Update github.com/evanphx/json-patch to e83c0a1c26c884f8ec4fb743f6db92a941f605f1 #92455

wants to merge 1 commit into from

Conversation

tapih
Copy link
Contributor

@tapih tapih commented Jun 24, 2020 •
edited
Loading

Signed-off-by: Hiroshi Muraoka h.muraoka714@gmail.com

What type of PR is this?
/kind bug

What this PR does / why we need it:
This PR fixes a bug that JSON patch with kubectl apply has exponential time complexity for the nesting depth of manifest.

Which issue(s) this PR fixes:

Fixes #91615 .

Special notes for your reviewer:

Backport of #92069 to the branch release-1.16.
git cherry-pick breaks the dependencies described in go.mod , so I simply executed the following commands instead:

./hack/pin-dependency.sh github.com/evanphx/json-patch e83c0a1c26c884f8ec4fb743f6db92a941f605f1
./hack/update-vendor.sh
./hack/lint-dependencies.sh

Does this PR introduce a user-facing change?:

Fixed a performance issue applying json patches to deeply nested objects

/cc @liggitt

@tapih
Update github.com/evanphx/json-patch to e83c0a1c26c884f8ec4fb743f6db9…
403396d 
…2a941f605f1

Signed-off-by: Hiroshi Muraoka <h.muraoka714@gmail.com>
@k8s-ci-robot k8s-ci-robot requested a review from liggitt June 24, 2020 04:19
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jun 24, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Jun 24, 2020
@k8s-ci-robot
Copy link
Contributor

@tapih: This cherry pick PR is for a release branch and has not yet been approved by Release Managers.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved (/lgtm + /approve) by the relevant OWNERS.

AFTER it has been approved by code owners, please ping the kubernetes/release-managers team in a comment to request a cherry pick review.

(For details on the patch release process and schedule, see the Patch Releases page.)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 24, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @tapih. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 24, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tapih
To complete the pull request process, please assign lavalamp
You can assign the PR to them by writing /assign @lavalamp in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes area/kubectl sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 24, 2020
@tapih tapih changed the title [v1.16] Update github.com/evanphx/json-patch to e83c0a1c26c884f8ec4fb743f6db9… [v1.16] Update github.com/evanphx/json-patch to e83c0a1c26c884f8ec4fb743f6db92a941f605f1 Jun 24, 2020
@liggitt
Copy link
Member

liggitt commented Jun 24, 2020

on review, the json-patch fix is not actually correct... opened evanphx/json-patch#108

@fedebongio
Copy link
Contributor

/assign @cheftako

@liggitt
Copy link
Member

liggitt commented Aug 8, 2020

/close

in favor of #93813 which includes evanphx/json-patch#108

@k8s-ci-robot
Copy link
Contributor

@liggitt: Closed this PR.

In response to this:

/close

in favor of #93813 which includes evanphx/json-patch#108

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@cheftako cheftako

Labels
area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. kind/bug Categorizes issue or PR as related to a bug. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.
5 participants
@tapih @k8s-ci-robot @liggitt @fedebongio @cheftako
Morty Proxy This is a proxified and sanitized view of the page, visit original site.