Fix typo and generate specs, so docs can be regenerated. #57758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mbohlool According to your description of the process, I separated this into two commits and made master the target branch. |
|
@steveperry-53 Needs a |
|
/lgtm |
|
/approve no-issue |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker, steveperry-53, thockin Associated issue: #57525 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
Automatic merge from submit-queue (batch tested with PRs 57380, 57758). If you want to cherry-pick this change to another branch, please follow the instructions here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR is a second attempt at something I tried to do in #57525. I have revised the process according to guidance from @mbohlool.
The purpose of this PR is for me to learn the process of updating the Kubernetes API reference documentation, and then to document that process. I'm working on getting the process documented in PR 6366 in the kubernetes/website repository. Here's a preview of the new topic.
In the docs, I would like to refer to this PR as an example. So I have kept the change simple: fix one typo.
Related issues:
kubernetes/website#921
kubernetes/website#922
Special notes for your reviewer:
In the future, we might want to make the doc generation process a bit more automatic. But for now I think it's important to get the current process documented.
Release note: