-
Notifications
You must be signed in to change notification settings - Fork 40.7k
docs(core/v1): clarify that only 'storage' resource is valid in PVC r… #132174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The committers listed above are authorized under a signed CLA. |
Welcome @subashniraula6! |
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @subashniraula6. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: subashniraula6 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
…equests
What type of PR is this?
/kind documentation
What this PR does / why we need it:
This PR improves the documentation for the
PersistentVolumeClaim.spec.resources.requests
field by explicitly stating that only"storage"
is a valid resource key in PVCs.Currently,
kubectl explain
shows a generic map of string to quantity without clarifying thatcpu
andmemory
are not valid in this context. This can confuse users who assume PVCs support the same keys as container resource requests. This change helps clarify the intended usage and aligns with the Kubernetes storage documentation.Which issue(s) this PR is related to:
N/A
Special notes for your reviewer:
kubectl explain
output.Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: