DRA API: remove obsolete types from v1alpha3 #132000
Conversation
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
8cd65f5 to
7255199
Compare
|
|
||
| // The device this taint is attached to has the "effect" on | ||
| // any claim which does not tolerate the taint and, through the claim, | ||
| // to pods using the claim. | ||
| // | ||
| // +protobuf.options.(gogoproto.goproto_stringer)=false |
There was a problem hiding this comment.
This aligns the v1alpha3 API with how the beta APIs define DeviceTaint.
This goes a bit beyond "obsolete type removal", I just happened to run into this.
The v1alpha3 version is still needed for DeviceTaintRule, but the rest of the types and most structs became obsolete in v1.32 when we introduced v1beta1 and bumped the storage version to v1beta1. Removing them now simplifies adding new features because new fields don't need to be added to these obsolete types. This could have been done already in 1.33, but wasn't to minimize disrupting on-going work.
7255199 to
d3d2fce
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pohly The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@pohly: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test pull-kubernetes-integration Looks like a flake around a canceled API request in scheduler_perf, unrelated. |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 8555f48abb10b0c13bcca014bb8c51f29da9b185
|
|
/assign @liggitt For approval of obsolete API removal and some minor cleanups. /label api-review |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The v1alpha3 version is still needed for DeviceTaintRule, but the rest of the types and most structs became obsolete in v1.32 when we introduced v1beta1 and bumped the storage version to v1beta1.
Removing them now simplifies adding new features because new fields don't need to be added to these obsolete types. This could have been done already in 1.33, but wasn't to minimize disrupting on-going work.
Which issue(s) this PR fixes:
Related-to: kubernetes/enhancements#4381, #131903
Does this PR introduce a user-facing change?
/assign @mortent